Remove the crypto library

CHANGELOG.md

@@ -3,6 +3,12 @@
 As this project is pre 1.0, breaking changes may happen for minor version bumps.
 A breaking change will get clearly notified in this log.
 
+## In master
+
+- Remove the `crypto` library. This reduces the number of Node built-ins we have
+  to shim into the production bundle, and incidentally fixes a bug with
+  Angular 6.
+
 ## [v0.12.0](https://github.com/stellar/js-stellar-base/compare/v0.11.0...v0.12.0)
 
 - _Warning_ Calling TransactionBuilder without a `fee` param is now deprecated

package.json

@@ -90,6 +90,7 @@
     "minami": "^1.1.1",
     "mocha": "^5.2.0",
     "prettier": "^1.16.1",
+    "randombytes": "^2.1.0",
     "run-sequence": "^1.0.2",
     "sinon": "^1.14.1",
     "sinon-chai": "^2.7.0",

src/transaction.js

@@ -1,7 +1,6 @@
 import map from 'lodash/map';
 import each from 'lodash/each';
 import isString from 'lodash/isString';
-import crypto from 'crypto';
 import { xdr, hash } from './index';
 
 import { StrKey } from './strkey';
@@ -162,10 +161,7 @@ export class Transaction {
     }
 
     const signature = preimage;
-    const hashX = crypto
-      .createHash('sha256')
-      .update(preimage)
-      .digest();
+    const hashX = hash(preimage);
     const hint = hashX.slice(hashX.length - 4);
     this.signatures.push(new xdr.DecoratedSignature({ hint, signature }));
   }

test/unit/crypto_test.js

@@ -0,0 +1,28 @@
+import crypto from 'crypto';
+
+function expectBuffersToBeEqual(left, right) {
+  let leftHex = left.toString('hex');
+  let rightHex = right.toString('hex');
+  expect(leftHex).to.eql(rightHex);
+}
+
+/*
+  We want to replace the crypto library (a Node built-in) with one
+  that works on both server and browser.
+
+  Before we do that, we should make sure the new library does the
+  same thing as the old one. This is basically the only way crypto is
+  used on the site.
+*/
+
+it('new hashing function behaves like crypto', () => {
+  const input = 'I really hope this works';
+  const cryptoHash = crypto
+    .createHash('sha256')
+    .update(input)
+    .digest();
+
+  const newHash = StellarBase.hash(input);
+
+  expectBuffersToBeEqual(cryptoHash, newHash);
+});

test/unit/operation_test.js

@@ -1,5 +1,4 @@
 import BigNumber from 'bignumber.js';
-import crypto from 'crypto';
 import isString from 'lodash/isString';
 
 describe('Operation', function() {
@@ -392,10 +391,7 @@ describe('Operation', function() {
     it('creates a setOptionsOp with preAuthTx signer', function() {
       var opts = {};
 
-      var hash = crypto
-        .createHash('sha256')
-        .update('Tx hash')
-        .digest();
+      var hash = StellarBase.hash('Tx hash');
 
       opts.signer = {
         preAuthTx: hash,
@@ -416,10 +412,7 @@ describe('Operation', function() {
     it('creates a setOptionsOp with preAuthTx signer from a hex string', function() {
       var opts = {};
 
-      var hash = crypto
-        .createHash('sha256')
-        .update('Tx hash')
-        .digest('hex');
+      var hash = StellarBase.hash('Tx hash').toString('hex');
       expect(isString(hash)).to.be.true;
 
       opts.signer = {
@@ -441,10 +434,7 @@ describe('Operation', function() {
     it('creates a setOptionsOp with hash signer', function() {
       var opts = {};
 
-      var hash = crypto
-        .createHash('sha256')
-        .update('Hash Preimage')
-        .digest();
+      var hash = StellarBase.hash('Hash Preimage');
 
       opts.signer = {
         sha256Hash: hash,
@@ -465,10 +455,7 @@ describe('Operation', function() {
     it('creates a setOptionsOp with hash signer from a hex string', function() {
       var opts = {};
 
-      var hash = crypto
-        .createHash('sha256')
-        .update('Hash Preimage')
-        .digest('hex');
+      var hash = StellarBase.hash('Hash Preimage').toString('hex');
       expect(isString(hash)).to.be.true;
 
       opts.signer = {

test/unit/transaction_test.js

@@ -1,4 +1,4 @@
-import crypto from 'crypto';
+import randomBytes from 'randombytes';
 
 describe('Transaction', function() {
   it('constructs Transaction object from a TransactionEnvelope', function(done) {
@@ -102,11 +102,8 @@ describe('Transaction', function() {
     let asset = StellarBase.Asset.native();
     let amount = '2000';
 
-    let preimage = crypto.randomBytes(64);
-    let hash = crypto
-      .createHash('sha256')
-      .update(preimage)
-      .digest();
+    let preimage = randomBytes(64);
+    let hash = StellarBase.hash(preimage);
 
     let tx = new StellarBase.TransactionBuilder(source, { fee: 100 })
       .addOperation(
@@ -134,11 +131,7 @@ describe('Transaction', function() {
     let asset = StellarBase.Asset.native();
     let amount = '2000';
 
-    let preimage = crypto.randomBytes(2 * 64);
-    let hash = crypto
-      .createHash('sha256')
-      .update(preimage)
-      .digest();
+    let preimage = randomBytes(2 * 64);
 
     let tx = new StellarBase.TransactionBuilder(source, { fee: 100 })
       .addOperation(

yarn.lock

@@ -5914,6 +5914,13 @@ randomatic@^3.0.0:
     kind-of "^6.0.0"
     math-random "^1.0.1"
 
+randombytes@^2.1.0:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/randombytes/-/randombytes-2.1.0.tgz#df6f84372f0270dc65cdf6291349ab7a473d4f2a"
+  integrity sha512-vYl3iOX+4CKUWuxGi9Ukhie6fsqXqS9FE2Zaic4tNFD2N2QQaXOMFbuKK4QmDHC0JO6B1Zp41J0LpT0oR68amQ==
+  dependencies:
+    safe-buffer "^5.1.0"
+
 range-parser@^1.0.3, range-parser@^1.2.0, range-parser@~1.2.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/range-parser/-/range-parser-1.2.0.tgz#f49be6b487894ddc40dcc94a322f611092e00d5e"