Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getVersionInfo endpoint #1028

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Aug 13, 2024

^^ Title says it all

Fixes: #997

@psheth9 psheth9 self-assigned this Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Size Change: +3.64 kB (+0.03%)

Total Size: 12.2 MB

Filename Size Change
dist/stellar-sdk.js 6.8 MB +2.28 kB (+0.03%)
dist/stellar-sdk.min.js 5.36 MB +1.36 kB (+0.03%)

compressed-size-action

@psheth9 psheth9 changed the title [WIP]Add support for getVersionInfo endpoint Add support for getVersionInfo endpoint Aug 14, 2024
@psheth9 psheth9 marked this pull request as ready for review August 14, 2024 21:09
@psheth9 psheth9 requested a review from Shaptic August 14, 2024 21:28
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coupla small nits, otherwise LGTM! 👏

CHANGELOG.md Outdated Show resolved Hide resolved
src/rpc/server.ts Outdated Show resolved Hide resolved
@psheth9 psheth9 merged commit 72ec060 into master Aug 19, 2024
9 of 10 checks passed
@psheth9 psheth9 deleted the add-getVersionInfo-endpoint branch August 19, 2024 19:13
@Shaptic Shaptic mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support getVersionInfo in the RPC client (rpc.Server)
2 participants