Create new URI instead of passing serverUrl (Fix #379). #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Jul 24, 2019
| @@ -167,7 +167,7 @@ export class Server { | |||
| * @returns {Promise} Promise that resolves to the fee stats returned by Horizon. | |||
| */ | |||
| public async operationFeeStats(): Promise<any> { | |||
| const cb = new CallBuilder(this.serverURL); | |||
| const cb = new CallBuilder(URI(this.serverURL as any)); | |||
There was a problem hiding this comment.
@morleyzhi I'd do a refactor on a different PR, to pull this value in a getter, that way we don't have to remember to use URI each time we want to pass this around
There was a problem hiding this comment.
Sounds good. Another option is to have CallBuilder handle converting strings to URI objects.
morleyzhi
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The culprit was that we were passing a reference to serverURL which was getting modified in the builders.