Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to verify SEP0010 "Challenge" Transaction. #388

Merged
merged 13 commits into from
Jul 29, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jul 26, 2019

Fixes #369

Task

  • verify that transaction source account is equal to the server's signing key;
  • verify that transaction has time bounds set, and that current time is between the minimum and maximum bounds;
  • verify that transaction contains a single Manage Data operation and its source account is not null;
  • verify that transaction envelope has a correct signature by server's signing key;
  • verify that transaction envelope has a correct signature by the operation's source account;

Copy link
Contributor

@morleyzhi morleyzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General approach looks good!

src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
Make `verifyTxSignedBy` a public function so that it can be used by
others.
@abuiles abuiles requested a review from morleyzhi July 29, 2019 17:21
Copy link
Contributor

@morleyzhi morleyzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abuiles abuiles merged commit 4fcc739 into master Jul 29, 2019
@abuiles abuiles deleted the abuiles/verify-sep10-tx branch July 29, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate SEP0010 "Challenge" Transaction
2 participants