Fix #391: Remove instance check for MessageEvent on stream error. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `MessageEvent` will throw an error if you are running the SDK on Node (this API is not present in Node). This was added in the TypeScript migration to match the expected interface. Checking the `error` instance shouldn't be a concern on the SDK but the consumer, is up to the consumer what to do with an error. Additionally we shouldn't be hiding errors just because they don't match a given interface.
morleyzhi
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
MessageEventwill throw an error if you are running the SDK onNode (this API is not present in Node).
This was added in the TypeScript migration to match the expected
interface.
Checking the
errorinstance shouldn't be a concern on the SDK butthe consumer, is up to the consumer what to do with an
error. Additionally we shouldn't be hiding errors just because they
don't match a given interface.