Fix manage data value in SEP0010 challenge builder. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>The value must be a 64 byte long base64 encoded >cryptographic-quality random string We were generating a 64 bytes nonce which wasn't necessarily encoded in base64. Closes #395
ire-and-curses
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
Yeah, looks good! I wondered about adding a test for base64 conformance, like this: https://stackoverflow.com/questions/8571501/how-to-check-whether-a-string-is-base64-encoded-or-not
But I don't think it's worth it - we should just trust the encoder ;)
Agree, I added a test on the verify method, which I think should be good |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were generating a 64 bytes nonce which wasn't necessarily encoded in base64.
Closes #395