Also listen to stream events with addEventListener #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2019 11:10
Some EventSource polyfills (like one React Native package) support addEventListener but not onmessage / onerror. It's possible another polyfill will use onmessage but not addEventListener. So to be safe, use both.
morleyzhi
changed the title
|
Investigating some issues right now, one sec. |
…ds double-callbacks
morleyzhi
changed the title
|
Even though this was a real issue I came up against, I'm not sure it's our responsibility to change it. This came about because a polyfill didn't meet spec. It's probably worth fixing just because addEventListener is better supported, and allows for multiple events instead of one overwriting the other. |
abuiles
approved these changes
Aug 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some EventSource polyfills (like one React Native package) support addEventListener but not onmessage / onerror. It's possible other implementations could use onmessage but not addEventListener. So to be safe, use both.