Clone the passed URI in CallBuilder constructor, to not mutate the outside ref #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
@challet thanks for this! I think what you are proposing makes sense and avoid unexpected surprises.
@morleyzhi WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The passed URI arg is modified on a later
call()inside thecheckFiltermethod, while the outside reference still pointing on it, making it to change.It was most probably harmless since all the
CallBuilderimplementations are supposed to be constructed from inside aServermethod, where it seems they are already cloned by re-instantiating them (this.serverURLbeing already a URI instance) :I didn't removed those URI calls from
Servermethods and I rather ask for opinions here.