Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountCallBuilder : add two methods for query filter #474

Merged
merged 3 commits into from
Jan 1, 2020

Conversation

challet
Copy link
Contributor

@challet challet commented Dec 30, 2019

Following stellar/go#1835 and according to https://www.stellar.org/developers/horizon/reference/endpoints/accounts.html, adds the ability to filter by

  • account signer
  • account trustee of an asset

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@challet thanks for tackling this! It looks good to me. Do you think it would make sense to add real data in the tests scenarios?

@challet challet force-pushed the accountcallbuilder-asset-and-signer branch from 6f239c9 to 8876620 Compare January 1, 2020 15:18
@challet challet force-pushed the accountcallbuilder-asset-and-signer branch from 7347b4e to 424c3eb Compare January 1, 2020 15:32
@challet
Copy link
Contributor Author

challet commented Jan 1, 2020

@abuiles data responses added to the test cases.

Made me notice that several url formats are used along the tests, both in the axios mock fetches and in the HAL responses :

Sometimes one not matching the other in the same test case.

@abuiles
Copy link
Contributor

abuiles commented Jan 1, 2020

@challet

Made me notice that several url formats are used along the tests, both in the axios mock fetches and in the HAL responses

Good catch! Thanks for updating the tests to use the same path. I think it makes sense to settle on https://horizon-testnet.stellar.org in the examples - they might not be always valid since testnet resets, but that's fine.

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@challet Thanks! Btw, would you mind checking this for future commits https://github.com/pstadler/keybase-gpg-github - we try to have commits signed in our repos :)

@abuiles abuiles merged commit 3636579 into stellar:master Jan 1, 2020
@challet challet deleted the accountcallbuilder-asset-and-signer branch January 3, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants