Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use axios CancelToken to ensure timeout #482

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Use axios CancelToken to ensure timeout #482

merged 4 commits into from
Jan 30, 2020

Conversation

kalepail
Copy link
Contributor

@kalepail kalepail commented Jan 29, 2020

Axios timeout doesn't catch missing urls, e.g. those with no response so we use the axios cancel token to ensure the timeout.

axios/axios#2143
axios/axios#647 (comment)

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at the failed tests?

@kalepail kalepail requested a review from abuiles January 30, 2020 15:09
@abuiles abuiles merged commit 097b44e into stellar:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants