Add support for top-level offers end-point with account, selling, and buying filter. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Feb 3, 2020
| @@ -239,9 +239,7 @@ export class FederationServer { | |||
| } else { | |||
| return Promise.reject( | |||
| new BadResponseError( | |||
There was a problem hiding this comment.
I think this is not related with the PR, but came because of prettier. @tyvdh do you have prettier locally?
There was a problem hiding this comment.
Like in my ide? I don’t think so.
abuiles
commented
Feb 3, 2020
| this.url.segment("offers"); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
@rice2000 can you check the copy on the functions? thanks!
kalepail
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the
offersbuilder to support requests at the top level/offersroute.You can list all offers by doing
server.offers()or use any of the following filters:server.offers().accountId(accountId)server.offers().buying(asset)server.offers().selling(asset)This change introduces a breaking change since it changes the signature for the function
server.offers().Before if you wanted to list all the offers for a given account, you'll do
server.offers('accounts', accountID), now you need to doserver.offers().accountId(accountId).