Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetchTimebounds() #487

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fix fetchTimebounds() #487

merged 2 commits into from
Feb 5, 2020

Conversation

andywer
Copy link
Contributor

@andywer andywer commented Feb 5, 2020

Fixes reading the Date header from a horizon response. That issue used to prevent users from making any successful transactions if their local time on their device was off.

Fixes #305. Well, adding the Access-Control-Expose-Headers: Date header on the horizon's responses plus this patch fix the issue.

Techincal background: HTTP header names are case-insensitive, our JS objects are not – that's why axios auto-lower-cases them.

@abuiles
Copy link
Contributor

abuiles commented Feb 5, 2020

@andywer can you fix the broken tests?

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test

@andywer
Copy link
Contributor Author

andywer commented Feb 5, 2020

Fixed the test!

@abuiles abuiles merged commit 5607d31 into stellar:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetchTimebounds bug
2 participants