Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junk the _link omition for AccountResponse class #495

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Junk the _link omition for AccountResponse class #495

merged 1 commit into from
Feb 12, 2020

Conversation

kalepail
Copy link
Contributor

No description provided.

@abuiles
Copy link
Contributor

abuiles commented Feb 12, 2020

@tyvdh can you cleanup your git history? for some reason it has a bunch of things which are not related with this.

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, however I'll defer to @morleyzhi on why were links excluded originally.

@abuiles abuiles merged commit 6c9ff02 into stellar:master Feb 12, 2020
marcelosalloum added a commit to marcelosalloum/js-stellar-sdk that referenced this pull request Feb 12, 2020
…transaction-helpers-sep-10

* upstream/master:
  Fix broken link to Stellar logo+wordmark (stellar#496)
  Junk the _link omition for AccountResponse class (stellar#495)
  v4.0.0 - Horizon 1.0 support (stellar#488)
  Add is_authorized to BalanceLineAsset. (stellar#491)
  Update yarn.lock. (stellar#490)
  Typescript fixes (stellar#489)
@abuiles abuiles mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants