Fix broken link to Stellar logo+wordmark #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
approved these changes
Feb 12, 2020
marcelosalloum
added a commit
to marcelosalloum/js-stellar-sdk
that referenced
this pull request
Feb 12, 2020
…transaction-helpers-sep-10 * upstream/master: Fix broken link to Stellar logo+wordmark (stellar#496) Junk the _link omition for AccountResponse class (stellar#495) v4.0.0 - Horizon 1.0 support (stellar#488) Add is_authorized to BalanceLineAsset. (stellar#491) Update yarn.lock. (stellar#490) Typescript fixes (stellar#489)
Merged
leighmcculloch
added a commit
that referenced
this pull request
Mar 6, 2020
### What Update the URL for the Stellar logo image displayed at the top of the README. ### Why A new version of the stellar.org website was deployed and the image we were using is no longer available there. In #496 @tyvdh fixed the broken link. In stellar/.github#9 we added the logo to a GitHub repository so that we could reference it from one location that won't be affected by website changes that is easily accessible by any dev. Other repositories (stellar/stellar-protocol#569, stellar/stellar-core#2459, stellar/go#2363) are going to use the image from that central location and we should update this README to use the same one too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.