Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend offer call builder to return a single offer. #499

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Feb 18, 2020

This will allow people to load a single offer from Horizon using the following syntax:

server.offers().offer("1234")

Fixes #498.

@abuiles abuiles requested a review from a team February 18, 2020 17:24
@abuiles abuiles merged commit 3146c11 into master Feb 18, 2020
@abuiles abuiles deleted the offers-by-id branch February 18, 2020 17:46
marcelosalloum added a commit to marcelosalloum/js-stellar-sdk that referenced this pull request Feb 18, 2020
…ansaction-helpers-sep-10

* origin/master:
  Extend offer call builder to return a single offer. (stellar#499)
@abuiles abuiles mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

there seems to be no OfferDetails or GetOfferById function
2 participants