Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEP0029 memo required check. #516

Merged
merged 8 commits into from
Mar 25, 2020
Merged

Add SEP0029 memo required check. #516

merged 8 commits into from
Mar 25, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Mar 25, 2020

This PR extends server.submitTransaction to always run a memo required check before sending the transaction. Users can opt-out by setting skipMemoRequiredCheck to true:

server.submitTransaction(tx, {skipMemoRequiredCheck: true})

The check is only run if any of the operations included in transaction is of type

  • payment
  • pathPaymentStrictReceive
  • pathPaymentStrictSend
  • mergeAccount

If the transaction includes a memo, then memo required checked is skipped.

See SEP0029 for more information.

@abuiles abuiles linked an issue Mar 25, 2020 that may be closed by this pull request
4 tasks
@abuiles abuiles marked this pull request as ready for review March 25, 2020 17:50
@abuiles abuiles requested a review from a team March 25, 2020 17:50
src/server.ts Show resolved Hide resolved
src/server.ts Show resolved Hide resolved
src/server.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SEP 29 support
4 participants