Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[3] Implement missing filter logic related to buy side, captured by TODO comments #636

Closed
3 tasks done
nikhilsaraf opened this issue Dec 29, 2020 · 0 comments
Closed
3 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Dec 29, 2020

can find these comments with the following regex: ^.*TODO.*buy.*$

  • minPriceFilter
  • maxPriceFilter
  • priceFeedFilter

Remove any logic that prevents filters from working for the buy side once implementation is complete.

@nikhilsaraf nikhilsaraf added the bug Something isn't working label Dec 29, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.1 milestone Dec 29, 2020
@nikhilsaraf nikhilsaraf assigned debnil and nikhilsaraf and unassigned debnil Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants