Bug #1178 - use Timepoint on get_ledger_timestamp #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Discussed with @leighmcculloch and decided this won't make it this time around, so maybe never, who knows) |
leighmcculloch
approved these changes
Dec 2, 2023
Sorry, I don't remember this. We must have been past the point where we were changing the API. This relates to: Can this PR be repurposed to adding a new host function that returns Without this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1178
This would be an env-breaking change if we do later. But it's also not super important? We can paper it over in the SDK or ship a different function in the future.