You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently native test contracts don't do relative-to-absolute object handle translation the way VM frames do. In this way they lack a degree of fidelity with VM frames. When I initially implemented it I somehow forgot there actually is a central place we could do this, in the impl <T:VmCallerEnv> Env for T macro-generated impl in vmcaller_env.rs in common.
This is not a security issue nor a breaking change for any contracts in the wild. It would change the observable semantics of a small part of test contracts that you really shouldn't be looking at anyways (object numbers) while improving fidelity between VM and native testing (in terms of cost model accuracy and object numbers in case you were looking). So we should probably do it at some point in the future. But it doesn't have to happen right now.
The text was updated successfully, but these errors were encountered:
Currently native test contracts don't do relative-to-absolute object handle translation the way VM frames do. In this way they lack a degree of fidelity with VM frames. When I initially implemented it I somehow forgot there actually is a central place we could do this, in the
impl <T:VmCallerEnv> Env for T
macro-generated impl in vmcaller_env.rs in common.This is not a security issue nor a breaking change for any contracts in the wild. It would change the observable semantics of a small part of test contracts that you really shouldn't be looking at anyways (object numbers) while improving fidelity between VM and native testing (in terms of cost model accuracy and object numbers in case you were looking). So we should probably do it at some point in the future. But it doesn't have to happen right now.
The text was updated successfully, but these errors were encountered: