Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre_release_version from meta.rs #1378

Open
sisuresh opened this issue Apr 3, 2024 · 2 comments
Open

Remove pre_release_version from meta.rs #1378

sisuresh opened this issue Apr 3, 2024 · 2 comments

Comments

@sisuresh
Copy link
Contributor

sisuresh commented Apr 3, 2024

What problem does your feature solve?

pre_release_version was helpful for the development of protocol 20 because of how often we iterated on the protocol, but going forward, we won't breaki a non-vnext build intentionally. The interface version (which contains both the protocol version and pre-release version) has caused confusion in the past, so we should just remove it.

@leighmcculloch
Copy link
Member

@leighmcculloch
Copy link
Member

leighmcculloch commented Sep 3, 2024

Now that we've separated the protocol and pre-release version in:

If we wanted to remove the pre-release version in the future we could do so by simply stopping using it, and renaming the field from preRelease to reserved or deprecated, just expecting it to be forever zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@leighmcculloch @sisuresh and others