Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic release not updating version in package.json #5

Closed
nokome opened this issue Jul 29, 2019 · 0 comments
Closed

Semantic release not updating version in package.json #5

nokome opened this issue Jul 29, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@nokome
Copy link
Member

nokome commented Jul 29, 2019

Semantic release is creating a git tag and updating CHANGELOG, but is not updating the version in package.json. This affects all our repos using @stencila/semantic-release-config. For example in Encoda:

nokome@pluto ~/s/s/encoda (master)> git describe --tags
v0.60.3
nokome@pluto ~/s/s/encoda (master)> cat package.json | grep version
  "version": "0.59.2",

The current version in package.json was updated by me manually, some time ago when I first noticed this bug.

It can be confirmed to be due to moving to using this repo:

  • in commit 4c9add1b2b2be574a88f0d792158112c21c846a1 stencila-ci incremented the version in package.json and added the v0.50.0 git tag
  • in the next commit 3b6ac04bf5749a0b18f6f0645fa1a03d40ee3589 we changed the semantic release config to be "extends": "@stencila/semantic-release-config"
  • in the next release f13405229432735cc52b24a66dc3fe61fd1499c5 the CHANGELOG is updated, but not package.json

I think this may have to do with how https://github.com/semantic-release/npm resolves which package.json to update.

@nokome nokome added the bug Something isn't working label Jul 29, 2019
@nokome nokome closed this as completed in 1fbd2bc Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant