-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks to catch linting issues and prevent credential leaks #2069
Comments
@Devils-Knight please take this up |
What hooks should we be recommending for linting and for credential scanning? For credential scanning, the options are For linting, there are some basic non-language-specific options like |
Would it be possible to use other libraries as well that do similar things with commit hooks? Mainly https://github.com/typicode/husky |
Thanks a lot for sharing @WikiRik! I did not know about |
This is done and released. https://app.stepsecurity.io/securerepo now shows an option to add pre-commit hooks. |
https://github.com/pre-commit/pre-commit is a framework for managing and maintaining multi-language pre-commit hooks.
It is very popular, and one of the important use cases is to detect and prevent credentials from being pushed. This is important because the cost of dealing with a cred leak is much higher once it is already pushed.
Using a PR, we should add a pre-commit configuration
.pre-commit-config.yaml
as a best practice. If the file already exists, then we should suggest adding specific hooks related to security.Here is an example of such a file
https://github.com/aws-samples/aws-deployment-pipeline-reference-architecture/blob/1329e3cb20f3ef782fca907ddce39d94a8b4c813/examples/cdk-application-pipeline/.pre-commit-config.yaml
The text was updated successfully, but these errors were encountered: