Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there a try! in the codebase? #1290

Open
DanielEdrisian opened this issue Dec 17, 2024 · 0 comments
Open

Why is there a try! in the codebase? #1290

DanielEdrisian opened this issue Dec 17, 2024 · 0 comments

Comments

@DanielEdrisian
Copy link

Build Information

  • Include the SQLite.swift version, commit or branch experiencing the issue.
    0.15.3

  • Mention Xcode and OS X versions affected.
    All

  • How do do you integrate SQLite.swift in your project?

    • Swift Package manager

General guidelines

In Core/Statement.swift, this try! causes a crash on some of my users:
Screenshot 2024-12-16 at 6 22 00 PM

It happens when trying db.prepare. When the function is already throwable, it should be expected that it never fatally crashes the app, but rather throw an error which I could either catch or ignore.
Screenshot 2024-12-16 at 6 28 32 PM

That way I could act on the error. Otherwise this is not good for the UX. Would really appreciate any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant