-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager #560
Conversation
@wadetregaskis is there a way to refer to the system CSQLite target instead of including the amalgamation? |
b2f0145
to
83e5175
Compare
Target(name: "SQLiteObjc") | ||
], | ||
dependencies: [ | ||
.Package(url: "https://github.com/jberkel/CSQLite.git", majorVersion: 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephencelis this should probably be moved to your namespace – I couldn't find a way to avoid a separate repository. there's something like dependency pinning now but it seems to be a newer feature, it's not on my system.
574d58f
to
845d7a2
Compare
@stephencelis could you just check the one comment above – basically need you to clone the repo. also, great stuff regarding today's Kickstarter OSS announcement, just a bit disappointed that there's no sign of SQLite.swift in the iOS app :) |
…tually be built and used correctly.
…indirectly via SQLiteObjc.
…if nothing else match the existing Xcode project name.
• Added a [hopefully] temporary workaround to allow building within the existing Xcode project to work as it did before, in addition to command-line builds via `swift`.
Fix paths Fix up podspec Run tests with package manager missing space Update changelog Fix variable expansion Fix quoting More quoting Don’t use env variable Rename Update doc Try build only Link ref Add to index Sans quotes Doc Simplify podspec Update docs Update planning doc Missing closing quote yml doc Capitalization Remove ALL_IN_ONE_BUILD Use system sqlite3 Fix import Fix bridging header Fixing paths
845d7a2
to
3656d9e
Compare
@jberkel Thanks! Sorry for the delay. I've forked the dependent repo in case you wanted to make things consistent! Yeah, the app is mostly online-only right now, so no need for a lib like SQLite.swift 😛, which might also show why my participation here has waned a bit—it's much harder to actively maintain libraries that you're not currently using. Happy holidays! Thanks again for being an invaluable contributor! |
Supersedes #548