-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4 support #668
Swift 4 support #668
Conversation
Fix usages of old Swift 2 enum case names
" ".join([ | ||
return " ".join(clauses.join.map { arg in | ||
let (type, query, condition) = arg | ||
return " ".join([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis sneakily replaced the Xcode 8.3 image
Thanks for getting the ball rolling. Hope travis will release a new Xcode image soon. |
The old way shown causes a build error in swift 3 (XCode8): Ambiguous reference to member 'print(_:separator:terminator:)'
Fix demonstration of how to trace SQL statements in docs
Updating swift 4 branch from master
So actually Travis succeeds, the only fails are in the validator schemes where there's some kind of timeout. The same commit has succeeded in Travis for my own branch : https://travis-ci.org/thebluepotato/SQLite.swift/builds/248984684. |
I updated my Podfile as such: any thoughts? thanks |
@abunur Well that's because the |
@thebluepotato lol my bad sorry :) |
@thebluepotato so after switching to your branch, doing a pod install --repo-update |
@abunur I've tried switching to the latest release, |
@thebluepotato thanks! looks like there aren't any massive changes in swift4. and the simulator test instability bug is back... |
@jberkel Indeed, when I closed and reopened the PR yesterday to trigger a rebuild, Travis worked completely but merging the most recent commit from |
What changes:
import CSQLite
with the newimport SQLite3
directly exposed to Swift code.map
syntax regarding tuples.The aim of this PR is to have code that compiles without issues with Swift 4/Xcode 9. All tests pass, except for those regarding SQLCipher, which haven't been tested.
pod lib lint
fails due to errors relating to SQLCipher. My guess is that there needs to be some tweaking on how SQLCipher is imported in Swift now that there's a native access to the SQLite API.