-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks with incremental builds #44
Comments
Hey @mcintyret - which plugins are you using that seem to be failing? Thanks for raising :) |
I saw the issue with both hard-source-webpack-plugin and fork-ts-checker-webpack-plugin |
Okay cool, thanks. I'll try my best to get some time this week to have a look at those and see why they're having issues 🤔 |
Break incremental builds too:
|
@stephencookdev I really like this plugin any progress on this? Any pointers to look at for fixing this? |
So the issue of But the issue of the Either, this Or, Longer term, I really want to expand our integration tests to be able to check incremental builds, as well as just plain builds. It makes testing + fixing issues a lot easier, if nothing else... Unfortunately I'm really struggling to find time to work on this repo at the moment! Any help would be massively appreciated 🙏 I'll try my best to write up a decent CONTRIBUTING.md in the next couple of days |
Similar issue with webpack-manifest-plugin@2.0.4, speed-measure-webpack-plugin@1.2.3: My manifest options are set as follows:
And getting the following err after the first build:
Hard to reproduce such a large app but hopefully the additional logs will help debug. |
I thought I would chip in here and add my 2-cents.
Is occurring for me when using
I will keep playing and update if I get any ideas where/why it is falling over. |
Is there any solution to this problem now? |
I hacked this into if (compiler.hooks) {
if (!compiler.hooks.webpackManifestPluginAfterEmit) {
compiler.hooks.compilation.tap({
name: 'ManifestPlugin',
stage: Infinity
}, function (compilation) {
compilation.applyPluginsAsync('webpack-manifest-plugin-after-emit', manifest, compileCallback);
});
} else {
compiler.hooks.webpackManifestPluginAfterEmit.call(manifest);
}
} else {
compilation.applyPluginsAsync('webpack-manifest-plugin-after-emit', manifest, compileCallback);
} |
Is there any update on this issue? I am also facing the same issue with ts-fork plugin. |
Several plugins I have tried to use alongside this plugin break when webpack starts an incremental build after a code change. The issue seems to be that all the hooks registered on the webpack 4
compiler.hooks
object are missing in the incremental compile. The plugins then fail with errors likeTypeError: Cannot read property 'call' of undefined
. Removing the speed-measure-webpack-plugin fixes the issue.The text was updated successfully, but these errors were encountered: