Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no-file-descriptor setting for outputSchema option #1047

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

lukealvoeiro
Copy link
Collaborator

@lukealvoeiro lukealvoeiro commented May 29, 2024

Description

When the outputSchema setting is enabled, it generated an object containing a fileDescriptor entry. Depending on the proto file, the associated value can be very large. This PR allows consumers of ts-proto to reap the benefits of the output schema, while minimizing the overall size of the object by removing the fileDescriptor entry.

Testing

  • Created a new integration directory with a unit test to capture regressions
  • Existing unit test cases pass

@lukealvoeiro
Copy link
Collaborator Author

lukealvoeiro commented May 30, 2024

@stephenh I've noticed these diffs being generated even on main. Can you confirm whether you experience this too? Or... maybe its just an issue when I run on my machine.

@lukealvoeiro lukealvoeiro force-pushed the lalvoeiro/no-file-descriptor-in-output-schema branch from 4555740 to 9bc8691 Compare June 4, 2024 21:46
@stephenh
Copy link
Owner

stephenh commented Jun 5, 2024

@lukealvoeiro yeah, I had noticed it failing on main ... finally was able to get it fixed in #1050 . I think if you rebase this PR, things should work! 🤞 Thank you!

@lukealvoeiro lukealvoeiro force-pushed the lalvoeiro/no-file-descriptor-in-output-schema branch from 9bc8691 to 72b4e87 Compare June 7, 2024 20:57
@lukealvoeiro lukealvoeiro merged commit c54f06c into main Jun 7, 2024
6 checks passed
@lukealvoeiro lukealvoeiro deleted the lalvoeiro/no-file-descriptor-in-output-schema branch June 7, 2024 21:36
stephenh pushed a commit that referenced this pull request Jun 7, 2024
# [1.178.0](v1.177.0...v1.178.0) (2024-06-07)

### Features

* `no-file-descriptor` setting for outputSchema option ([#1047](#1047)) ([c54f06c](c54f06c))
@stephenh
Copy link
Owner

stephenh commented Jun 7, 2024

🎉 This PR is included in version 1.178.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants