fix: Compilation error for nested repeated fields with useOptionals=all
#1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vecerek
changed the title
useOptionals=all
stephenh
approved these changes
Sep 29, 2024
| } | ||
|
|
||
| const el = StringValue.decode(reader, reader.uint32()).value; | ||
| if (el) { |
There was a problem hiding this comment.
@vecerek if el was an empty string, we probably want to still .push it? I.e. should we just for undefined instead of truthiness?
There was a problem hiding this comment.
Yes, you're correct! I'll make that change and I've just noticed I didn't push the re-generated TS files and I noticed another problem related to multiple case statements:
Cannot redeclare block-scoped variable 'el'.ts(2451)
I'll have to wrap the cases in a block to address this issue.
There was a problem hiding this comment.
@stephenh I've just force-pushed the rest of the changes. Thank you for the swift review!
…ll (stephenh#1112) The TS code generated for the following protobuf code with the `useOptionals=all` parameter does not compile. ```proto syntax = "proto3"; import "google/protobuf/wrappers.proto"; message NestedList { repeated google.protobuf.StringValue a_string = 1; } message Example { NestedList list = 1; } ``` The problem lies in the `decode` function not taking into account that the `value` after decoding could also be `undefined`. Therefore the following generated line: ```ts message.aString!.push(StringValue.decode(reader, reader.uint32()).value); ``` results in the following TS compilation error: ``` Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.ts(2345) ``` The fix is to push the decoded element to the array only if it's not an `undefined` value.
vecerek
force-pushed
the
avecerek-fix-repeated-fields-with-use-optional
branch
from
5d2ffd3
to
08981bf
Compare
|
🎉 This issue has been resolved in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112.
The fix is to push the decoded element to the array only if it's not an
undefinedvalue.