Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix encode wrap types #303

Merged
merged 4 commits into from
May 23, 2021
Merged

fix: Fix encode wrap types #303

merged 4 commits into from
May 23, 2021

Conversation

stephenh
Copy link
Owner

No description provided.

@stephenh stephenh mentioned this pull request May 23, 2021
Closed
stephenh
stephenh commented May 23, 2021
View reviewed changes
integration/grpc-js/grpc-js-test.ts

client.unary({}, (err, res) => {
expect(res).toEqual({});
});

client.unaryStringValue('foobar', (error: ServiceError | null, response: string | undefined) => {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcraescu thanks for the comprehensive set of tests here!

@stephenh stephenh merged commit 533c0e0 into main May 23, 2021
@stephenh stephenh deleted the fix_encode_wrap_types branch May 23, 2021 19:19
stephenh pushed a commit that referenced this pull request May 23, 2021
@semantic-release-bot
chore(release): 1.81.1 [skip ci]
86751fc 
## [1.81.1](v1.81.0...v1.81.1) (2021-05-23)

### Bug Fixes

* Fix encode wrap types ([#303](#303)) ([533c0e0](533c0e0))
@stephenh
Copy link
Owner Author

🎉 This PR is included in version 1.81.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenh @vcraescu