Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve import collisions for enums #341

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

doochik
Copy link
Collaborator

@doochik doochik commented Aug 3, 2021

Similar to #339. Also fixes generated functions

Sorry, my fault. I've tested collisions for types and haven't tested for JSON methods

Similar to stephenh#339. Also fixes generated functions
chunks.push(code`export function ${camelCase(fullName)}ToNumber(object: ${fullName}): number {`);

const functionName = camelCase(fullName) + 'ToNumber';
chunks.push(code`export function ${def(functionName)}(object: ${fullName}): number {`);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, interesting wrinkle. Makes sense!

@doochik
Copy link
Collaborator Author

doochik commented Aug 3, 2021

@stephenh What I need to release new version? Just merge it to main?

@doochik doochik merged commit 50fe34e into stephenh:main Aug 4, 2021
stephenh pushed a commit that referenced this pull request Aug 4, 2021
## [1.82.4](v1.82.3...v1.82.4) (2021-08-04)

### Bug Fixes

* resolve import collisions for enums ([#341](#341)) ([50fe34e](50fe34e))
@stephenh
Copy link
Owner

stephenh commented Aug 4, 2021

🎉 This PR is included in version 1.82.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh
Copy link
Owner

stephenh commented Aug 4, 2021

What I need to release new version? Just merge it to main?

@doochik Yep! I was kind of a late adopter, but a coworker got me hooked on the semantic-release tool suite that does a pretty great job of automating releases, in terms of doing tags / changelog / github release / npm upload / etc.

@doochik
Copy link
Collaborator Author

doochik commented Aug 4, 2021

What I need to release new version? Just merge it to main?

@doochik Yep! I was kind of a late adopter, but a coworker got me hooked on the semantic-release tool suite that does a pretty great job of automating releases, in terms of doing tags / changelog / github release / npm upload / etc.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants