fix: fix codegen for maps with wrapper value type

[aikoven]

Before this fix a map<string, google.protobuf.StringValue> would generate invalid TypeScript code like

message.mapOfStringValues[key] = string | undefined.fromJSON(value);

Fixes #182

[aikoven]

I had to push the google/protobuf/timestamp.ts to make CI happy. It has a slight difference to the one in the repo, probably due to a different version of protoc.

[stephenh]

Cool, thanks!

[aikoven]

Thank you for your review @stephenh.

I've updated the tests, though there are some questions regarding undefined values behavior.

I'm not sure whether we should preserve them in generated objects. In the wire format, we can distinguish between a missing map entry and an empty entry value. But in the generated code if we erase the undefined values, we can't distinguish between the two.

On the other hand, we already drop map entries with empty values if that map has a message value type.

Anyway, maps with wrapper value types seem like a marginal case to me, and I only need them to work to support third-party protobufs. So I'd be happy even if we lose some strictness.

[stephenh]

@aikoven cool, this looks good to me. I think you're changes look good, and yeah I'm good with loosing some strictness too, in terms of being pragmatic. I mostly wanted tests that at least documented what we do today, so that we know when/if it changes, which I think this current round does pretty well.

Feel free to continuing making pragmatic decisions and merge whenever the build passes. :-) Thanks!

[aikoven]

I ended up skipping entries with undefined values when encoding these maps. This made pbjs happy as well.

Feel free to continuing making pragmatic decisions and merge whenever the build passes. :-) Thanks!

All tests pass now and I think that the PR is ready to merge. But I don't have the merge button:

[stephenh]

Ah shoot! I thought I'd invited you as a collaborator already, but actually had not; just sent an invite.

[aikoven]

Great, thanks!

[stephenh]

🎉 This PR is included in version 1.83.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀