-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to long 5.0.0 for ESM support #377
Comments
when do you plan to update? |
@badeAdebayo I'm not personally planning on working on this soon; PR's would be great if you're interested! |
i am running into an issue importing ts-proto files into an oclif command, and i think this would fix it.
search and replace gets it working (but not sure if that will break something else) in the meantime is there a way to avoid this? |
Same issue here |
same issue |
Same issue |
With --ts_proto_opt=esModuleInterop=true changes output to be esModuleInterop compliant. Specifically the Long imports will be generated as import Long from 'long' instead of import * as Long from 'long'. |
I've merged #882 that: a) upgrades ts-proto's internal usages of But, as @Eashiong as noted, if you're using We should probably make |
In theory some of our import hacks can go away now? Probably needs to be a breaking change for ts-proto as well.
The text was updated successfully, but these errors were encountered: