fix: code generation for int64 map values in fromPartial and fromJson #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchroederChris
changed the title
|
@SchroederChris thanks for the PR; I've added some tests and a few more fixes. Going to merge, thanks! |
stephenh
pushed a commit
that referenced
this pull request
Nov 21, 2021
## [1.87.1](v1.87.0...v1.87.1) (2021-11-21) ### Bug Fixes * code generation for int64 map values in fromPartial and fromJson ([#395](#395)) ([d3ea8eb](d3ea8eb))
|
🎉 This PR is included in version 1.87.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for the quick merge! While implementing the changes in our codebase, I realized that it might be a good idea to also use |
|
@SchroederChris ah sure! That sgtm. Can you submit a PR with that change? Thanks! |
|
👍 here it is: #405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stephenh,
I noticed that with
--ts_proto_opt=forceLong=long, if you have a map with an int64 value (e.g.map<string, int64> data), the generated typescript code infromJSONandfromPartialwasn't correct (it fell back tomessage.data[key] = Long(value), which didn't compile). I changed that to useLong.fromStringinfromJSON(int64 should always be string in JSON, right?) andLong.fromValueinfromPartial.As we don't use binary protobuf, I only checked these two methods.
Also, I unfortunately didn't figure out how to add a test for this, so I'll leave this to you.
Kind regards!