Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Round numbers in toJSON. #444

Merged
merged 4 commits into from
Dec 14, 2021
Merged

feat: Round numbers in toJSON. #444

merged 4 commits into from
Dec 14, 2021

Conversation

stephenh
Copy link
Owner

@stephenh stephenh commented Dec 13, 2021

Fixes #433 .

On 2nd thought, I think I'd probably prefer toJSON actually blowing up in this case, instead of silently dropping fractional numbers, but this seems fine for now.

@stephenh stephenh merged commit bd2df7b into main Dec 14, 2021
@stephenh stephenh deleted the round-numbers-in-to-json branch December 14, 2021 17:30
stephenh pushed a commit that referenced this pull request Dec 14, 2021
# [1.94.0](v1.93.3...v1.94.0) (2021-12-14)

### Features

* Round numbers in toJSON. ([#444](#444)) ([bd2df7b](bd2df7b))
@stephenh
Copy link
Owner Author

🎉 This PR is included in version 1.94.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toJSON not verifiying ints are actualy ints
1 participant