Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect generateClientImpl=false in grpc-js (#471) #472

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix: respect generateClientImpl=false in grpc-js (#471) #472

merged 1 commit into from
Jan 10, 2022

Conversation

alexeyten
Copy link
Contributor

Do not generate client stub and constructor when outputServices=grpc-js and outputClientImpl=false

@alexeyten
fix: respect generateClientImpl=false in grpc-js (stephenh#471)
8d41f1c 
Do not generate client stub and constructor when `outputServices=grpc-js` and `outputClientImpl=false`
@stephenh
Copy link
Owner

Great, thanks @alexeyten !

@stephenh stephenh merged commit 2f389f2 into stephenh:main Jan 10, 2022
stephenh pushed a commit that referenced this pull request Jan 10, 2022
@semantic-release-bot
chore(release): 1.100.1 [skip ci]
2e4cb6b 
## [1.100.1](v1.100.0...v1.100.1) (2022-01-10)

### Bug Fixes

* respect generateClientImpl=false in grpc-js ([#471](#471)) ([#472](#472)) ([2f389f2](2f389f2))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.100.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh stephenh mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeyten @stephenh