perf: Faster base64FromBytes & bytesFromBase64 on Node.JS #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coyotte508 looks great! Looks like there are a few test failures/need the |
coyotte508
changed the title
|
The failing test was caused because expecting a Uint8Array instead of a Buffer (even though Buffer is a subclass of Uint8Array and is type-compatible since node 4.x). I used |
|
Thanks @coyotte508 , I'll hit merge! |
stephenh
pushed a commit
that referenced
this pull request
Aug 7, 2022
## [1.121.4](v1.121.3...v1.121.4) (2022-08-07) ### Performance Improvements * Faster base64FromBytes & bytesFromBase64 on Node.JS ([#649](#649)) ([82ab341](82ab341))
|
🎉 This PR is included in version 1.121.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't change the browser code but
for .. ofwould probably be more performant thanforEachon it