feat: RPC: add useAbortSignal option #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some unused variables triggering "unused variable" warnings. Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 13, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
force-pushed
the
abort-controller
branch
from
b80126f to
b1b5254
Compare
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 13, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
force-pushed
the
abort-controller
branch
from
b1b5254 to
fe4fabd
Compare
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 13, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 13, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
|
@stephenh This should be good to go now. I wonder too about passing an AbortSignal on the server side. |
Adds a new option "useAbortSignal" which adds an optional AbortSignal parameter to RPC functions. AbortController and AbortSignal are built-ins in both Node.JS and all web browsers, which implement aborting long-lived processes. For example: const abortController = new AbortController() const responsePromise = rpcClient.DoSomething(request, abortController.signal) // abort the RPC call early abortController.abort() Fixes stephenh#730 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
force-pushed
the
abort-controller
branch
from
fe4fabd to
f51c0d9
Compare
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 14, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
|
🎉 This PR is included in version 1.136.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 14, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 14, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 14, 2022
Currently adds 1 patch for the following pending PR: - stephenh/ts-proto#730 - stephenh/ts-proto#731 Signed-off-by: Christian Stewart <christian@paral.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option "useAbortSignal" which adds an optional AbortSignal parameter to RPC functions. AbortController and AbortSignal are built-ins in both Node.JS and all web browsers, which implement aborting long-lived processes.
For example:
Fixes #730