Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--forceLong=bigint doesn't handle array of int64 correctly #749

Closed
zfy0701 opened this issue Dec 31, 2022 · 3 comments · Fixed by #751
Closed

--forceLong=bigint doesn't handle array of int64 correctly #749

zfy0701 opened this issue Dec 31, 2022 · 3 comments · Fixed by #751
Labels
released

Comments

@zfy0701
Copy link

zfy0701 commented Dec 31, 2022 

message XXX {
  repeated uint64 yyy = 4;
}

will generate code like:

  encode(message: EvmGetHeaderRequest, writer: _m0.Writer = _m0.Writer.create()): _m0.Writer {
    for (const v of message.blockNumbers) {
      writer.uint64(v);
    }  },

which doesn't work since uint64 can't take bigint
@azizghuloum
Copy link
Contributor

This is unfortunate that the test suite didn't catch it. Will attempt a fix.

@azizghuloum
Copy link
Contributor

#751

@azizghuloum azizghuloum mentioned this issue Jan 4, 2023
Merged
@stephenh
Copy link
Owner

stephenh commented Jan 9, 2023

🎉 This issue has been resolved in version 1.137.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: repeated uint64 fields do not encode properly with bigint option azizghuloum/ts-proto
3 participants
@stephenh @zfy0701 @azizghuloum