feat: Add type annotations flag #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ekrekr this looks great! Looks like a build failure, hopefully minor but I haven't had a chance to take a look, can you see if it's an easy fix? Thanks! |
Ekrekr
commented
May 2, 2023
There was a problem hiding this comment.
Have fixed this now - culprit was a options.outputTypeRegistry || options.outputTypeRegistry rather than options.outputTypeAnnotations || options.outputTypeRegistry.
Was having trouble with having to do docker-compose with no --rm vs docker compose previously so couldn't run tests locally, but got it working now.
src/main.ts
Outdated
| @@ -688,7 +695,8 @@ function makeTimestampMethods(options: Options, longs: ReturnType<typeof makeLon | |||
| seconds = "Math.trunc(date.getTime() / 1_000).toString()"; | |||
| } | |||
|
|
|||
| const maybeTypeField = options.outputTypeRegistry ? `$type: 'google.protobuf.Timestamp',` : ""; | |||
| const maybeTypeField = | |||
| options.outputTypeRegistry || options.outputTypeRegistry ? `$type: 'google.protobuf.Timestamp',` : ""; | |||
|
Looks great, thanks @Ekrekr ! |
stephenh
pushed a commit
that referenced
this pull request
May 2, 2023
# [1.147.0](v1.146.0...v1.147.0) (2023-05-02) ### Features * Add type annotations flag ([#786](#786)) ([b565ff5](b565ff5))
|
🎉 This PR is included in version 1.147.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780