Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output-encode-only methods #787

Merged
merged 7 commits into from
Mar 8, 2023
Merged

feat: output-encode-only methods #787

merged 7 commits into from
Mar 8, 2023

Conversation

Frabat
Copy link
Contributor

@Frabat Frabat commented Mar 1, 2023

As requested by me in #773, I've changed the outputEncodeMethods to accept also "encode-only" and "decode-only" string values.
Since my use case also didn't need the creation methods, I've added a third option "encode-no-creation" that doesn't export that.
In theory, this could be included with the "encode-only" flag, since the creation method is used just by the encoder, but somebody might need it.

Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Frabat looks like the build failed with a prettier error, but otherwise looks good to me! Thanks!

@Frabat
Copy link
Contributor Author

Frabat commented Mar 6, 2023

Hi @stephenh can I solve the prettier error or is something CI related?

@stephenh
Copy link
Owner

stephenh commented Mar 6, 2023

@Frabat if you run yarn format in the root directory, it should resolve the prettier errors, and then just push those changes up to the PR.

@Frabat
Copy link
Contributor Author

Frabat commented Mar 6, 2023

@stephenh done!

@stephenh
Copy link
Owner

stephenh commented Mar 8, 2023

Erg, sorry for the flakey tests, I think we had several tests sharing the same port. I believe I've fixed it in:

#790

Can you rebase on top of that / on top of main? Thank you!

@Frabat
Copy link
Contributor Author

Frabat commented Mar 8, 2023

@stephenh never mind! Rebased!

@stephenh
Copy link
Owner

stephenh commented Mar 8, 2023

Looks great! Thanks @Frabat !

@stephenh stephenh merged commit 3594410 into stephenh:main Mar 8, 2023
stephenh pushed a commit that referenced this pull request Mar 8, 2023
# [1.141.0](v1.140.0...v1.141.0) (2023-03-08)

### Features

* output-encode-only methods ([#787](#787)) ([3594410](3594410))
@stephenh
Copy link
Owner

stephenh commented Mar 8, 2023

🎉 This PR is included in version 1.141.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants