Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Observable as type #825

Closed
spheenik opened this issue May 6, 2023 · 2 comments
Closed

Import Observable as type #825

spheenik opened this issue May 6, 2023 · 2 comments

Comments

@spheenik
Copy link
Contributor

spheenik commented May 6, 2023

Hi,

first of all, great project, using it with a lot of joy.

I have a small feature request. I am using the generated code in a svelte project, where the tsconfig.js does have

"importsNotUsedAsValues": "error"

This gives me a tslint error in the generated api.ts, because it imports Observable as

import { Observable } from "rxjs";

instead of

import type { Observable } from "rxjs";

I was trying to come up with a pull request, but I can't seem to find where it happens. I saw in tspoet that it supports importing as type, so maybe it'll take you only a minute. Not really a big deal though, I can simply add it everytime after compiling the API.

@stephenh
Copy link
Owner

stephenh commented May 7, 2023

Fixed by #826 , thanks @spheenik !

@stephenh stephenh closed this as completed May 7, 2023
@spheenik
Copy link
Contributor Author

spheenik commented May 7, 2023

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants