It maybe !observer.closed => observer.closed when set returnObservable=true

[lyhanburger]

ts-proto/src/generate-grpc-web.ts

Line 386 in 75f9f4a

if (!observer.closed) return client.close()

it seems like

if (observer.closed)  return client.close();

because when call the unsubscribe() the closed set be true.

current code, make me can not close the grpc streamimg response

[stephenh]

Hi @KiyomiHan , I'm not sure and honestly am not really following; @hersentino I think wrote the code you linked to; Francois lmk if you have any thoughts on ^. Thanks!

[hersentino]

Hi,

I'm not sure if this condition is the real issue here. I've tried removing it locally and used the unsubscribe function, but it seems like the add callback is never triggered. @KiyomiHan Can you test this on your end to confirm whether it works without the condition or not? You can use yalc to easily link your local ts-proto project to your project.

I initially added this condition to prevent the close function from being called again if it has already been closed by the abort signal system. So, the condition can safely be removed, but as I mentioned earlier, I don't think this will resolve your problem.

I'm not an expert with observable, but I believe the issue here is that the add callback is not being called even when the subscription is unsubscribed. I'm trying to figure out why. The add callback was already implemented when I introduced the abort signal system. I'm not sure if it was working or not at that time

Why don't you use the abort signal system instead of the unsubscribe method? The abort signal system is functioning properly

[hersentino]

Okay, I made a mistake in my previous comment. The add callback works absolutely fine!
I am able to reproduce the bug locally. Additionally, by removing my condition, an abort is successfully triggered when the 'unsubscribe' method is called.

Sorry about the confusion. I'm going to submit a pull request today

[hersentino]

The added condition to the pr is required, If I remove the condition, an error is triggered when the stream is aborted. This is why I initially wrote the faulty condition

This error occurs because the close event is triggered twice: once by the abort event and once by the unsubscribe event.

With this pull request, everything works fine, both with and without the useAbortSignal option. I have tested both cases locally.

[stephenh]

This should be fixed by #837. Thanks @hersentino !