feat: expose service name as separate exported constant #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
reviewed
Jun 20, 2023
stephenh
approved these changes
Jun 20, 2023
The service name (for example, "simple.Echoer") is currently hidden within the constructor of the service implementation. While it's possible to override the service name with a constructor parameter, we should also export this ServiceName constant so it can be used elsewhere. Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
force-pushed
the
feat-export-service-id
branch
from
4e83558
to
a380260
Compare
|
Refactored -> ...ServiceName |
paralin
changed the title
|
Looks great, thanks @paralin ! |
stephenh
pushed a commit
that referenced
this pull request
Jun 20, 2023
# [1.150.0](v1.149.0...v1.150.0) (2023-06-20) ### Features * expose service name as a separate exported constant ([#851](#851)) ([84a4ed6](84a4ed6))
|
🎉 This PR is included in version 1.150.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service ID (for example, "simple.Echoer") is currently hidden within the constructor of the service implementation.
While it's possible to override the service ID with a constructor parameter, we should also export this ServiceID constant so that it can be used elsewhere.