fix: Don't close client if we've already aborted #968
Merged
+35
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
changed the title
stephenh
approved these changes
Nov 24, 2023
|
Cool, thanks sense! |
|
@stephenh thx for the quick review! Would appreciate a release |
stephenh
pushed a commit
that referenced
this pull request
Nov 28, 2023
|
@bouk ah shoot, those are supposed to happen automatically but looks like the commit message was missing the I just force-pushed your commit with the |
stephenh
pushed a commit
that referenced
this pull request
Nov 28, 2023
## [1.164.2](v1.164.1...v1.164.2) (2023-11-28) ### Bug Fixes * Don't close client if we've already aborted ([#968](#968)) ([7ee1507](7ee1507))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc-web throw an error if you close the client after it's already been closed:
https://github.com/improbable-eng/grpc-web/blob/1d9bbb09a0990bdaff0e37499570dbc7d6e58ce8/client/grpc-web/src/client.ts#L327
This can happen with the abort signals if the observer is finished first and then the abort signal is triggered, causing an exception. Here I'm changing the code generator to remove the abort signal listener in the observer finish handler.