fix: error handling on non-Error type errors
#983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thanks @lukealvoeiro ! |
stephenh
pushed a commit
that referenced
this pull request
Dec 31, 2023
## [1.166.2](v1.166.1...v1.166.2) (2023-12-31) ### Bug Fixes * error handling on non-Error type errors ([#983](#983)) ([8c567fc](8c567fc))
|
🎉 This PR is included in version 1.166.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small issue noticed with the behavior of the default service implementation
handleErrormethod. If the throw error was an instance of Error, then the handleError function is called correctly. However, if it was not, we had a check that preventedhandleErrorfrom called. This isn't desired behavior as errors can be strings.Testing performed
Tested in a consuming application and this issue is resolved. Unit tests have been updated and are passing.