Allow --add-location parameter #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow usage of the --add-location parameter. By default, the location consists of a hash, colon, file name and line number. In more recent versions of xgettext, this can be altered to 'none' or 'file'. The default value is 'full', but this is implied when the parameter is missing. I want to remove the line numbers from the .pot-file, because they change frequently and this causes differences in the .pot-file that are not really changes, but do show op in the versioning system each time.
|
@stephenharris Please accept this PR or comment on it. |
|
Hello Stephen, thanks for responding. To answer your first question: By default, the --add-location argument will not be added to the xgettext call. This ensures compatibility with existing configurations. I know that the --add-location argument was added at some point, but cannot find a changelog of xgettext. So I could not tell you what would happen for older versions of xgettext. I presume they will give an error. |
|
Ah, of course, not sure how I missed that. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usage of the --add-location parameter. By default, the location
consists of a hash, colon, file name and line number. In more recent
versions of xgettext, this can be altered to 'none' or 'file'. The
default value is 'full', but this is implied when the parameter is
missing.
I want to remove the line numbers from the .pot-file, because they
change frequently and this causes differences in the .pot-file that are
not really changes, but do show op in the versioning system each time.