Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _get_val_from_obj with value_from_object #1980

Merged

Conversation

petedermott
Copy link
Contributor

Fix for #1977, I believe this functionality was just duplicated functionality and the method has been replaced.

See https://code.djangoproject.com/ticket/24716 for more info

@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -94,7 +94,7 @@ def validate(self, value, instance):
raise ValidationError(error)

def value_to_string(self, obj):
value = self._get_val_from_obj(obj)
value = self.value_to_string(obj)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Wasn't it supposed to be value_from_object?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was suppose to be value_from_object. The change made now causes an infinite recursion when serializing the field (for example, with dumpdata).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a PR for this #1999

@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants