Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date-fns dependency #394

Open
AleksandrTermenzhy opened this issue Aug 9, 2024 · 0 comments
Open

date-fns dependency #394

AleksandrTermenzhy opened this issue Aug 9, 2024 · 0 comments

Comments

@AleksandrTermenzhy
Copy link
Contributor

Given that the main feature of the library explicitly depends on date-fns, I wonder if there any downside to putting it as a direct dependency instead of a combination of dev+peer dependencies?
Doing so would also allow to remove the recommendation in the README to add the date-fns library explicitly to a project.

Additional observations: if someone omits the recommended step of adding date-fns as an explicit dependency, the behavior will differ depending on the package manager used: npm will install the peerDependency, while yarn will not, resulting in a broken build.

To sum up, I would like to know if there is any history behind not putting date-fns as a direct dependency, and if not, are you open to doing otherwise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant