Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option of inheriting labels and/or annotations #2

Closed
stepro opened this issue Jun 1, 2020 · 0 comments · Fixed by #34
Closed

Allow option of inheriting labels and/or annotations #2

stepro opened this issue Jun 1, 2020 · 0 comments · Fixed by #34
Labels
suggestion A suggestion to be discussed
Milestone

Comments

@stepro
Copy link
Owner

stepro commented Jun 1, 2020

While the default "safe" choice when inheriting an existing configuration is to not inherit labels and annotations, there will clearly be cases where doing so is beneficial. The current behavior is largely there to prevent inheriting configuration for a pod that is selected by a service, because that would cause the kdo pod to be automatically included in load balancing for the service.

It's possible that the current default is wrong. Options are:

  • By default, the --inherit flag means inherit everything, and there's a way to opt out of inheriting labels and annotations (just like there is to not inherit lifecycle and probes);
  • The current default makes sense and inheriting labels and annotations are opt-in;
  • The default is "smart" based on whether what is being inherited is a service or not.
@stepro stepro added the suggestion A suggestion to be discussed label Jun 1, 2020
@stepro stepro added this to the Backlog milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion to be discussed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant