Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(biome): do not use stdin due to biome bug with emojis #120

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix(biome): do not use stdin due to biome bug with emojis #120

merged 1 commit into from
Oct 6, 2023

Conversation

chrisgrieser
Copy link
Contributor

Due to this bug (biomejs/biome#455), using stdin will break some emojis. Until the bug is fixed, the biome formatter should therefore write the file in-place, since the bug does not occur in that case.

@stevearc
Copy link
Owner

stevearc commented Oct 6, 2023

LGTM thanks!

@stevearc stevearc merged commit e5ed063 into stevearc:master Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants